b72a46db68
Some checks failed
Update All Top Ranking Issues / update_top_ranking_issues (push) Has been cancelled
Triage Project Sync (#84) / Sync triage project (push) Has been cancelled
release_nightly / notify_on_failure (push) Has been cancelled
release_nightly / check_style (push) Has been cancelled
release_nightly / run_tests_windows (push) Has been cancelled
release_nightly / clippy_windows (push) Has been cancelled
release_nightly / bundle_linux_aarch64 (push) Has been cancelled
release_nightly / bundle_linux_x86_64 (push) Has been cancelled
release_nightly / bundle_mac_aarch64 (push) Has been cancelled
release_nightly / bundle_mac_x86_64 (push) Has been cancelled
release_nightly / bundle_windows_aarch64 (push) Has been cancelled
release_nightly / bundle_windows_x86_64 (push) Has been cancelled
release_nightly / build_nix_linux_x86_64 (push) Has been cancelled
release_nightly / build_nix_mac_aarch64 (push) Has been cancelled
release_nightly / update_nightly_tag (push) Has been cancelled
Hotfix Review Monitor / check-hotfix-reviews (push) Has been cancelled
Stale PR Review Reminder / check-stale-prs (push) Has been cancelled
Update Weekly Top Ranking Issues / update_top_ranking_issues (push) Has been cancelled
Bump collab-staging Tag / update-collab-staging-tag (push) Has been cancelled
compliance_check / scheduled_compliance_check (push) Has been cancelled
Single-commit orphan branch: full zed-industries/zed @ 8c74db0 source tree with a 3-file patch applied (no upstream history). Patch (crates/gpui_linux/src/linux/wayland/): - serial.rs: add SerialKind::KeyboardEnter - client.rs: store wl_keyboard.enter serial; add latest_serial_of() - window.rs: activate() uses keyboard-enter serial (Mutter focus gate) Mutter honors window activation only when the token carries the keyboard- focus serial from wl_keyboard.enter; GPUI used a stale mouse-press serial. See docs/tray-window-focus-wayland.md in logiguard. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
103 lines
3.3 KiB
TypeScript
103 lines
3.3 KiB
TypeScript
import { danger, message, warn, fail } from "danger";
|
|
const { prHygiene } = require("danger-plugin-pr-hygiene");
|
|
|
|
prHygiene({
|
|
prefixPattern: /^([a-z\d\(\)_\s]+):(.*)/g,
|
|
rules: {
|
|
// Don't enable this rule just yet, as it can have false positives.
|
|
useImperativeMood: "off",
|
|
noConventionalCommits: {
|
|
bannedTypes: ["feat", "fix", "style", "refactor", "perf", "test", "chore", "build", "revert"],
|
|
},
|
|
},
|
|
});
|
|
|
|
const RELEASE_NOTES_PATTERN = /Release Notes:(\r?\n)+- /gm;
|
|
const body = danger.github.pr.body;
|
|
|
|
const hasReleaseNotes = RELEASE_NOTES_PATTERN.test(body);
|
|
|
|
if (!hasReleaseNotes) {
|
|
warn(
|
|
[
|
|
"This PR is missing release notes.",
|
|
"",
|
|
'Please add a "Release Notes" section that describes the change:',
|
|
"",
|
|
"```",
|
|
"Release Notes:",
|
|
"",
|
|
"- Added/Fixed/Improved ...",
|
|
"```",
|
|
"",
|
|
'If your change is not user-facing, you can use "N/A" for the entry:',
|
|
"```",
|
|
"Release Notes:",
|
|
"",
|
|
"- N/A",
|
|
"```",
|
|
].join("\n"),
|
|
);
|
|
}
|
|
|
|
const ISSUE_LINK_PATTERN =
|
|
/(?:- )?(?<!(?:Close[sd]?|Fixe[sd]|Resolve[sd]|Implement[sed]|Follow-up of|Part of):?\s+)https:\/\/github\.com\/[\w-]+\/[\w-]+\/issues\/\d+/gi;
|
|
|
|
const bodyWithoutReleaseNotes = hasReleaseNotes ? body.split(/Release Notes:/)[0] : body;
|
|
const includesIssueUrl = ISSUE_LINK_PATTERN.test(bodyWithoutReleaseNotes);
|
|
|
|
if (includesIssueUrl) {
|
|
const matches = bodyWithoutReleaseNotes.match(ISSUE_LINK_PATTERN) ?? [];
|
|
const issues = matches
|
|
.map((match) => match.replace(/^#/, "").replace(/https:\/\/github\.com\/zed-industries\/zed\/issues\//, ""))
|
|
.filter((issue, index, self) => self.indexOf(issue) === index);
|
|
|
|
const issuesToReport = issues.map((issue) => `#${issue}`).join(", ");
|
|
message(
|
|
[
|
|
`This PR includes links to the following GitHub Issues: ${issuesToReport}`,
|
|
"If this PR aims to close an issue, please include a `Closes #ISSUE` line at the top of the PR body.",
|
|
].join("\n"),
|
|
);
|
|
}
|
|
|
|
const MIGRATION_SCHEMA_FILES = [
|
|
"crates/collab/migrations/20251208000000_test_schema.sql",
|
|
"crates/collab/migrations.sqlite/20221109000000_test_schema.sql",
|
|
];
|
|
|
|
const modifiedSchemaFiles = danger.git.modified_files.filter((file) =>
|
|
MIGRATION_SCHEMA_FILES.some((schemaFilePath) => file.endsWith(schemaFilePath)),
|
|
);
|
|
|
|
if (modifiedSchemaFiles.length > 0) {
|
|
warn(
|
|
[
|
|
"This PR modifies database schema files.",
|
|
"",
|
|
"If you are making database changes, a migration needs to be added in the Cloud repository.",
|
|
].join("\n"),
|
|
);
|
|
}
|
|
|
|
const FIXTURE_CHANGE_ATTESTATION = "Changes to test fixtures are intentional and necessary.";
|
|
|
|
const FIXTURES_PATHS = ["crates/assistant_tools/src/edit_agent/evals/fixtures"];
|
|
|
|
const modifiedFixtures = danger.git.modified_files.filter((file) =>
|
|
FIXTURES_PATHS.some((fixturePath) => file.includes(fixturePath)),
|
|
);
|
|
|
|
if (modifiedFixtures.length > 0) {
|
|
if (!body.includes(FIXTURE_CHANGE_ATTESTATION)) {
|
|
const modifiedFixturesStr = modifiedFixtures.map((path) => "`" + path + "`").join(", ");
|
|
fail(
|
|
[
|
|
`This PR modifies eval or test fixtures (${modifiedFixturesStr}), which are typically expected to remain unchanged.`,
|
|
"If these changes are intentional and required, please add the following attestation to your PR description: ",
|
|
`"${FIXTURE_CHANGE_ATTESTATION}"`,
|
|
].join("\n\n"),
|
|
);
|
|
}
|
|
}
|