logiguard fork: GPUI xdg-activation keyboard-focus serial fix
Update All Top Ranking Issues / update_top_ranking_issues (push) Has been cancelled
release_nightly / notify_on_failure (push) Has been cancelled
release_nightly / check_style (push) Has been cancelled
release_nightly / run_tests_windows (push) Has been cancelled
release_nightly / clippy_windows (push) Has been cancelled
release_nightly / bundle_linux_aarch64 (push) Has been cancelled
release_nightly / bundle_linux_x86_64 (push) Has been cancelled
release_nightly / bundle_mac_aarch64 (push) Has been cancelled
release_nightly / bundle_mac_x86_64 (push) Has been cancelled
release_nightly / bundle_windows_aarch64 (push) Has been cancelled
release_nightly / bundle_windows_x86_64 (push) Has been cancelled
release_nightly / build_nix_mac_aarch64 (push) Has been cancelled
release_nightly / update_nightly_tag (push) Has been cancelled
Hotfix Review Monitor / check-hotfix-reviews (push) Has been cancelled
Stale PR Review Reminder / check-stale-prs (push) Has been cancelled
Update Weekly Top Ranking Issues / update_top_ranking_issues (push) Has been cancelled
Triage Project Sync (#84) / Sync triage project (push) Has been cancelled
release_nightly / build_nix_linux_x86_64 (push) Has been cancelled
Bump collab-staging Tag / update-collab-staging-tag (push) Has been cancelled
compliance_check / scheduled_compliance_check (push) Has been cancelled
Update All Top Ranking Issues / update_top_ranking_issues (push) Has been cancelled
release_nightly / notify_on_failure (push) Has been cancelled
release_nightly / check_style (push) Has been cancelled
release_nightly / run_tests_windows (push) Has been cancelled
release_nightly / clippy_windows (push) Has been cancelled
release_nightly / bundle_linux_aarch64 (push) Has been cancelled
release_nightly / bundle_linux_x86_64 (push) Has been cancelled
release_nightly / bundle_mac_aarch64 (push) Has been cancelled
release_nightly / bundle_mac_x86_64 (push) Has been cancelled
release_nightly / bundle_windows_aarch64 (push) Has been cancelled
release_nightly / bundle_windows_x86_64 (push) Has been cancelled
release_nightly / build_nix_mac_aarch64 (push) Has been cancelled
release_nightly / update_nightly_tag (push) Has been cancelled
Hotfix Review Monitor / check-hotfix-reviews (push) Has been cancelled
Stale PR Review Reminder / check-stale-prs (push) Has been cancelled
Update Weekly Top Ranking Issues / update_top_ranking_issues (push) Has been cancelled
Triage Project Sync (#84) / Sync triage project (push) Has been cancelled
release_nightly / build_nix_linux_x86_64 (push) Has been cancelled
Bump collab-staging Tag / update-collab-staging-tag (push) Has been cancelled
compliance_check / scheduled_compliance_check (push) Has been cancelled
Single-commit orphan branch: full zed-industries/zed @ 8c74db0 source tree with a 3-file patch applied (no upstream history). Patch (crates/gpui_linux/src/linux/wayland/): - serial.rs: add SerialKind::KeyboardEnter - client.rs: store wl_keyboard.enter serial; add latest_serial_of() - window.rs: activate() uses keyboard-enter serial (Mutter focus gate) Mutter honors window activation only when the token carries the keyboard- focus serial from wl_keyboard.enter; GPUI used a stale mouse-press serial. See docs/tray-window-focus-wayland.md in logiguard. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,317 @@
|
||||
use crate::PredictionProvider;
|
||||
use crate::paths::WORKTREES_DIR;
|
||||
use crate::qa::QaResult;
|
||||
use anyhow::{Context as _, Result};
|
||||
use collections::HashMap;
|
||||
use edit_prediction::example_spec::ExampleSpec;
|
||||
use edit_prediction::udiff::OpenedBuffers;
|
||||
use gpui::Entity;
|
||||
use http_client::Url;
|
||||
use language::{Anchor, Buffer};
|
||||
use project::Project;
|
||||
use serde::{Deserialize, Serialize};
|
||||
use std::{
|
||||
borrow::Cow,
|
||||
collections::VecDeque,
|
||||
io::Read,
|
||||
path::{Path, PathBuf},
|
||||
};
|
||||
use zeta_prompt::ZetaPromptInput;
|
||||
|
||||
#[derive(Clone, Debug, Serialize, Deserialize)]
|
||||
pub struct Example {
|
||||
#[serde(flatten)]
|
||||
pub spec: ExampleSpec,
|
||||
|
||||
/// The full content of the file where an edit is being predicted, and the
|
||||
/// actual cursor offset.
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
pub prompt_inputs: Option<ZetaPromptInput>,
|
||||
|
||||
/// The input and expected output from the edit prediction model.
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
pub prompt: Option<ExamplePrompt>,
|
||||
|
||||
/// The actual predictions from the model.
|
||||
#[serde(default, skip_serializing_if = "Vec::is_empty")]
|
||||
pub predictions: Vec<ExamplePrediction>,
|
||||
|
||||
/// The scores, for how well the actual predictions match the expected
|
||||
/// predictions.
|
||||
#[serde(default, skip_serializing_if = "Vec::is_empty")]
|
||||
pub score: Vec<ExampleScore>,
|
||||
|
||||
/// QA evaluation results for each prediction (indexed parallel to `predictions`).
|
||||
#[serde(default, skip_serializing_if = "Vec::is_empty")]
|
||||
pub qa: Vec<Option<QaResult>>,
|
||||
|
||||
/// The Zed version used to generate this example.
|
||||
pub zed_version: Option<String>,
|
||||
|
||||
/// The application state used to process this example.
|
||||
#[serde(skip)]
|
||||
pub state: Option<ExampleState>,
|
||||
}
|
||||
|
||||
#[derive(Clone, Debug)]
|
||||
pub struct ExampleState {
|
||||
pub project: Entity<Project>,
|
||||
pub buffer: Entity<Buffer>,
|
||||
pub cursor_position: Anchor,
|
||||
pub _open_buffers: OpenedBuffers,
|
||||
}
|
||||
|
||||
#[derive(Clone, Debug, Serialize, Deserialize)]
|
||||
pub struct ExamplePrompt {
|
||||
pub input: String,
|
||||
#[serde(default)]
|
||||
pub expected_output: Option<String>,
|
||||
pub rejected_output: Option<String>, // For DPO
|
||||
#[serde(default)]
|
||||
pub prefill: Option<String>,
|
||||
pub provider: PredictionProvider,
|
||||
}
|
||||
|
||||
#[derive(Clone, Debug, Serialize, Deserialize)]
|
||||
pub struct ExamplePrediction {
|
||||
#[serde(default, skip_serializing_if = "Option::is_none")]
|
||||
pub actual_patch: Option<String>,
|
||||
#[serde(deserialize_with = "deserialize_null_as_empty_string")]
|
||||
pub actual_output: String,
|
||||
#[serde(default, skip_serializing_if = "Option::is_none")]
|
||||
pub actual_cursor: Option<ActualCursor>,
|
||||
#[serde(default, skip_serializing_if = "Option::is_none")]
|
||||
pub error: Option<String>,
|
||||
pub provider: PredictionProvider,
|
||||
#[serde(default, skip_serializing_if = "Option::is_none")]
|
||||
pub cumulative_logprob: Option<f64>,
|
||||
#[serde(default, skip_serializing_if = "Option::is_none")]
|
||||
pub avg_logprob: Option<f64>,
|
||||
}
|
||||
|
||||
#[derive(Clone, Debug, Serialize, Deserialize)]
|
||||
pub struct ActualCursor {
|
||||
pub path: String,
|
||||
pub row: u32,
|
||||
pub column: u32,
|
||||
pub offset: usize,
|
||||
#[serde(default, skip_serializing_if = "Option::is_none")]
|
||||
pub editable_region_offset: Option<usize>,
|
||||
}
|
||||
|
||||
impl ActualCursor {
|
||||
/// Construct an `ActualCursor` from a cursor offset within the new editable region.
|
||||
///
|
||||
/// - `path`: file path the cursor is in
|
||||
/// - `editable_region_cursor_offset`: byte offset of the cursor within the new editable region text
|
||||
/// - `new_editable_region`: the full new editable region text (after marker removal)
|
||||
/// - `content`: the full file content (before the edit)
|
||||
/// - `editable_region_byte_offset`: byte offset where the editable region starts in `content`
|
||||
/// - `editable_region_start_line`: 0-based line number where the editable region starts in `content`
|
||||
pub fn from_editable_region(
|
||||
path: &std::path::Path,
|
||||
editable_region_cursor_offset: usize,
|
||||
new_editable_region: &str,
|
||||
content: &str,
|
||||
editable_region_byte_offset: usize,
|
||||
editable_region_start_line: usize,
|
||||
) -> Self {
|
||||
let global_offset = editable_region_byte_offset + editable_region_cursor_offset;
|
||||
let new_region_prefix = &new_editable_region[..editable_region_cursor_offset];
|
||||
let row = (editable_region_start_line + new_region_prefix.matches('\n').count()) as u32;
|
||||
let column = match new_region_prefix.rfind('\n') {
|
||||
Some(pos) => (editable_region_cursor_offset - pos - 1) as u32,
|
||||
None => {
|
||||
let content_prefix = &content[..editable_region_byte_offset];
|
||||
let content_column = match content_prefix.rfind('\n') {
|
||||
Some(pos) => editable_region_byte_offset - pos - 1,
|
||||
None => editable_region_byte_offset,
|
||||
};
|
||||
(content_column + editable_region_cursor_offset) as u32
|
||||
}
|
||||
};
|
||||
ActualCursor {
|
||||
path: path.to_string_lossy().to_string(),
|
||||
row,
|
||||
column,
|
||||
offset: global_offset,
|
||||
editable_region_offset: Some(editable_region_cursor_offset),
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn deserialize_null_as_empty_string<'de, D>(deserializer: D) -> Result<String, D::Error>
|
||||
where
|
||||
D: serde::Deserializer<'de>,
|
||||
{
|
||||
let opt = Option::<String>::deserialize(deserializer)?;
|
||||
Ok(opt.unwrap_or_default())
|
||||
}
|
||||
|
||||
pub type ExampleScore = edit_prediction_metrics::PredictionScore;
|
||||
|
||||
impl Example {
|
||||
pub fn repo_name(&self) -> Result<RepoName<'_>> {
|
||||
// git@github.com:owner/repo.git
|
||||
if self.spec.repository_url.contains('@') {
|
||||
let (owner, repo) = self
|
||||
.spec
|
||||
.repository_url
|
||||
.split_once(':')
|
||||
.context("expected : in git url")?
|
||||
.1
|
||||
.split_once('/')
|
||||
.context("expected / in git url")?;
|
||||
Ok(RepoName {
|
||||
owner: Cow::Borrowed(owner),
|
||||
name: Cow::Borrowed(repo.trim_end_matches(".git")),
|
||||
})
|
||||
// http://github.com/owner/repo.git
|
||||
} else {
|
||||
let url = Url::parse(&self.spec.repository_url)?;
|
||||
let mut segments = url.path_segments().context("empty http url")?;
|
||||
let owner = segments
|
||||
.next()
|
||||
.context("expected owner path segment")?
|
||||
.to_string();
|
||||
let repo = segments
|
||||
.next()
|
||||
.context("expected repo path segment")?
|
||||
.trim_end_matches(".git")
|
||||
.to_string();
|
||||
assert!(segments.next().is_none());
|
||||
|
||||
Ok(RepoName {
|
||||
owner: Cow::Owned(owner),
|
||||
name: Cow::Owned(repo),
|
||||
})
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
pub struct RepoName<'a> {
|
||||
pub owner: Cow<'a, str>,
|
||||
pub name: Cow<'a, str>,
|
||||
}
|
||||
|
||||
impl RepoName<'_> {
|
||||
pub fn worktree_path(&self) -> PathBuf {
|
||||
WORKTREES_DIR
|
||||
.join(self.owner.as_ref())
|
||||
.join(self.name.as_ref())
|
||||
}
|
||||
}
|
||||
|
||||
pub fn read_example_files(inputs: &[PathBuf]) -> Vec<Example> {
|
||||
let mut examples = Vec::new();
|
||||
|
||||
for path in inputs {
|
||||
let is_stdin = path.as_path() == Path::new("-");
|
||||
let content = if is_stdin {
|
||||
let mut buffer = String::new();
|
||||
std::io::stdin()
|
||||
.read_to_string(&mut buffer)
|
||||
.expect("Failed to read from stdin");
|
||||
buffer
|
||||
} else {
|
||||
std::fs::read_to_string(path)
|
||||
.unwrap_or_else(|_| panic!("Failed to read path: {:?}", &path))
|
||||
};
|
||||
let filename = path.file_stem().unwrap().to_string_lossy().to_string();
|
||||
let ext = if !is_stdin {
|
||||
path.extension()
|
||||
.map(|ext| ext.to_string_lossy().to_string())
|
||||
.unwrap_or_else(|| panic!("{} should have an extension", path.display()))
|
||||
} else {
|
||||
"jsonl".to_string()
|
||||
};
|
||||
|
||||
match ext.as_ref() {
|
||||
"json" => {
|
||||
let mut example =
|
||||
serde_json::from_str::<Example>(&content).unwrap_or_else(|error| {
|
||||
panic!("Failed to parse example file: {}\n{error}", path.display())
|
||||
});
|
||||
if example.spec.name.is_empty() {
|
||||
example.spec.name = filename;
|
||||
}
|
||||
examples.push(example);
|
||||
}
|
||||
"jsonl" => examples.extend(
|
||||
content
|
||||
.lines()
|
||||
.enumerate()
|
||||
.map(|(line_ix, line)| {
|
||||
let mut example =
|
||||
serde_json::from_str::<Example>(line).unwrap_or_else(|error| {
|
||||
panic!(
|
||||
"Failed to parse example on {}:{}\n{error}",
|
||||
path.display(),
|
||||
line_ix + 1
|
||||
)
|
||||
});
|
||||
if example.spec.name.is_empty() {
|
||||
example.spec.name = format!("{filename}-{line_ix}")
|
||||
}
|
||||
example
|
||||
})
|
||||
.collect::<Vec<Example>>(),
|
||||
),
|
||||
"md" => {
|
||||
let mut example = parse_markdown_example(&content).unwrap();
|
||||
if example.spec.name.is_empty() {
|
||||
example.spec.name = filename;
|
||||
}
|
||||
examples.push(example);
|
||||
}
|
||||
ext => {
|
||||
panic!("{} has invalid example extension `{ext}`", path.display())
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
examples
|
||||
}
|
||||
|
||||
pub fn sort_examples_by_repo_and_rev(examples: &mut [Example]) {
|
||||
examples.sort_by(|a, b| {
|
||||
a.spec
|
||||
.repository_url
|
||||
.cmp(&b.spec.repository_url)
|
||||
.then(b.spec.revision.cmp(&a.spec.revision))
|
||||
});
|
||||
}
|
||||
|
||||
pub fn group_examples_by_repo(examples: Vec<Example>) -> VecDeque<Vec<Example>> {
|
||||
let mut examples_by_repo: HashMap<String, Vec<Example>> = HashMap::default();
|
||||
let mut ungrouped = Vec::new();
|
||||
for example in examples {
|
||||
if example.spec.repository_url.is_empty() {
|
||||
ungrouped.push(example);
|
||||
} else {
|
||||
examples_by_repo
|
||||
.entry(example.spec.repository_url.clone())
|
||||
.or_insert_with(Vec::new)
|
||||
.push(example);
|
||||
}
|
||||
}
|
||||
let mut result: VecDeque<Vec<Example>> = examples_by_repo.into_values().collect();
|
||||
for example in ungrouped {
|
||||
result.push_back(vec![example]);
|
||||
}
|
||||
result
|
||||
}
|
||||
|
||||
fn parse_markdown_example(input: &str) -> Result<Example> {
|
||||
let spec = ExampleSpec::from_markdown(input)?;
|
||||
Ok(Example {
|
||||
spec,
|
||||
prompt_inputs: None,
|
||||
prompt: None,
|
||||
predictions: Vec::new(),
|
||||
score: Vec::new(),
|
||||
qa: Vec::new(),
|
||||
state: None,
|
||||
zed_version: None,
|
||||
})
|
||||
}
|
||||
Reference in New Issue
Block a user