fix(helm): wrong savepoint path config when storage-type is filesystem

helm/chart/templates/flink/config.yaml

@@ -28,14 +28,16 @@
     state.backend.rocksdb.localdir: /opt/flink/rocksdb
     high-availability.storageDir: /opt/flink/ha
     {{- if eq .Values.flink.state.savepoint.storageType "filesystem" }}
-    state.savepoints.dir: file:///opt/flink/checkpoints/
+    state.savepoints.dir: file:///opt/flink/savepoints/
     {{- else if eq .Values.flink.state.savepoint.storageType "s3" }}
     state.savepoints.dir: s3://flink/savepoints/
     {{- end }}
     state.backend.incremental: {{ .Values.flink.state.incremental }}
     rest.profiling.enabled: true
+    {{- if or (eq .Values.flink.state.checkpoint.storageType "s3") (eq .Values.flink.state.savepoint.storageType "s3") }}
     s3.endpoint: http://{{ .Release.Name }}-minio:9000
     s3.path.style.access: true
+    {{- end }}
     {{- toYaml .Values.flink.properties | default "" | nindent 4 }}
     
 {{- end }}

helm/chart/templates/flink/job-manager-deploy.yaml

@@ -49,6 +49,7 @@ spec:
               valueFrom:
                 fieldRef:
                   fieldPath: status.podIP
+            {{- if or (eq .Values.flink.state.checkpoint.storageType "s3") (eq .Values.flink.state.savepoint.storageType "s3") }}
             - name: S3_ENDPOINT
               value: "http://minio-service:9000"
             - name: AWS_ACCESS_KEY_ID
@@ -61,6 +62,7 @@ spec:
                 secretKeyRef:
                   name: {{ .Release.Name }}-flink-secrets
                   key: minio_secret_key
+            {{- end }}
           volumeMounts:
             - name: flink-ha
               mountPath: {{ .Values.flink.state.ha.dir }}
@@ -70,7 +72,7 @@ spec:
             {{- end }}
             {{- if eq .Values.flink.state.savepoint.storageType "filesystem" }}
             - name: flink-savepoint
-              mountPath: /opt/flink/savepoint
+              mountPath: /opt/flink/savepoints
             {{- end }}
       volumes:
         - name: flink-ha

helm/chart/templates/flink/task-manager-statefulset.yaml

@@ -31,6 +31,7 @@ spec:
           valueFrom:
             fieldRef:
               fieldPath: status.podIP
+        {{- if or (eq .Values.flink.state.checkpoint.storageType "s3") (eq .Values.flink.state.savepoint.storageType "s3") }}
         - name: S3_ENDPOINT
           value: "http://minio-service:9000"
         - name: AWS_ACCESS_KEY_ID
@@ -43,6 +44,7 @@ spec:
             secretKeyRef:
               name: {{ .Release.Name }}-flink-secrets
               key: minio_secret_key
+        {{- end }}
         volumeMounts:
         - name: rocksdb-storage
           mountPath: /opt/flink/rocksdb
@@ -52,7 +54,7 @@ spec:
         {{- end }}
         {{- if eq .Values.flink.state.savepoint.storageType "filesystem" }}
         - name: flink-savepoint
-          mountPath: /opt/flink/savepoint
+          mountPath: /opt/flink/savepoints
         {{- end }}
         resources:
           {{- toYaml .Values.flink.taskManager.resources | nindent 10 }}